-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify FMV version selection rules #370
Conversation
The existing version selection rules are unclear, underspecified, and result in unintuitive version orderings. Replace this with a simpler explicit selection algorithm.
@jroelofs, you made a suggestion that cmdline options should affect the priority of versions. Would you like to discuss this further in this review? |
Adding @Wilco1 @DanielKristofKiss @rsandifo-arm @ilinpv to comment on the proposal llvm/llvm-project#118544 (comment). I am specifically refering to the impact of the cmdline on version selection. |
Hi @jroelofs. We had a discussion today about this and @andrewcarlotti had a valid point against cmdline influencing the priorities: Imagine three versions A, B and C being compiled with -march=<...>+A+B+C. The selection would be undefined. Shall we think a little more for other potential pros/cons? |
That's a great point. I'll concede on this entirely, given that counterexample. |
@andrewcarlotti can you rebase this? Then we should be able to merge if no objections. |
Currently, the more features a version has, the higher its priority is. We are changing ACLE ARM-software/acle#370 as follows: "Among any two versions, the higher priority version is determined by identifying the highest priority feature that is specified in exactly one of the versions, and selecting that version."
Currently, the more features a version has, the higher its priority is. We are changing ACLE ARM-software/acle#370 as follows: "Among any two versions, the higher priority version is determined by identifying the highest priority feature that is specified in exactly one of the versions, and selecting that version."
…1921) Currently, the more features a version has, the higher its priority is. We are changing ACLE ARM-software/acle#370 as follows: "Among any two versions, the higher priority version is determined by identifying the highest priority feature that is specified in exactly one of the versions, and selecting that version."
The existing version selection rules are unclear, underspecified, and result in unintuitive version orderings. Replace this with a simpler explicit selection algorithm.
name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.
Thank you for submitting a pull request!
If this PR is about a bugfix:
Please use the bugfix label and make sure to go through the checklist below.
If this PR is about a proposal:
We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.
We would like to encourage you reading through the contribution
guidelines, in particular the section on submitting
a proposal.
Please use the proposal label.
As for any pull request, please make sure to go through the below
checklist.
Checklist: (mark with
X
those which apply)PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
SPDX-FileCopyrightText
lines on topof any file I have edited. Format is
SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>
(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in
2017-2019
, and usecommas to separate gaps, as in
2018-2020, 2022
).Copyright
section of the sources of thespecification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
draftversion
is set totrue
in the YAML headerof the sources of the specifications I have modified.
in the README page of the project.